-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): upgrade to react 18 #700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
dependencies
Pull requests that update a dependency file
tech dept
Removes some technical debt
refactoring
Code refactoring without functional changes
labels
Nov 27, 2023
theborakompanioni
force-pushed
the
upgrade-react-18
branch
3 times, most recently
from
November 30, 2023 22:09
aa49c45
to
3889c0f
Compare
theborakompanioni
force-pushed
the
upgrade-react-18
branch
from
December 1, 2023 13:38
2c53dcc
to
b281208
Compare
editwentyone
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
refactoring
Code refactoring without functional changes
tech dept
Removes some technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally updates to react 18.
This is actually the third attempt to do so - but there were always to many PRs waiting, which would have introduced many merge conflicts. Now in calmer times, it was picked up again.
Run
npm install
after checkout.This updates most dependencies to their most recent versions.
Some behaviour had to be adapted (e.g. "success" step after importing a wallet), but all-in-all, it would work exactly as before.
Also noteworthy:
navigate
did not work anymore)📸
How to test
npm install
npm run dev:start